Commit 039ced63 authored by Tony Lindgren's avatar Tony Lindgren

Revert "I2C: Fix twl4030 timeouts on omap3430"

This reverts commit 621bce23.

This patch killed twl4030 interrupts.
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent ce1972e5
...@@ -327,7 +327,6 @@ int twl4030_i2c_read(u8 mod_no, u8 * value, u8 reg, u8 num_bytes) ...@@ -327,7 +327,6 @@ int twl4030_i2c_read(u8 mod_no, u8 * value, u8 reg, u8 num_bytes)
return -EPERM; return -EPERM;
} }
mutex_lock(&twl->xfer_lock); mutex_lock(&twl->xfer_lock);
/* [MSG1] fill the register address data */ /* [MSG1] fill the register address data */
msg = &twl->xfer_msg[0]; msg = &twl->xfer_msg[0];
msg->addr = twl->address; msg->addr = twl->address;
...@@ -335,31 +334,18 @@ int twl4030_i2c_read(u8 mod_no, u8 * value, u8 reg, u8 num_bytes) ...@@ -335,31 +334,18 @@ int twl4030_i2c_read(u8 mod_no, u8 * value, u8 reg, u8 num_bytes)
msg->flags = 0; /* Read the register value */ msg->flags = 0; /* Read the register value */
val = twl4030_map[mod_no].base + reg; val = twl4030_map[mod_no].base + reg;
msg->buf = &val; msg->buf = &val;
/*
* REVISIT: If we combine I2C write-read transfer, twl4030 can hang.
* The only difference is that I2C clocks are now cut inbetween write
* and read transfers.
*/
ret = i2c_transfer(twl->client.adapter, twl->xfer_msg, 1);
if (ret < 0)
goto out;
/* [MSG2] fill the data rx buffer */ /* [MSG2] fill the data rx buffer */
msg = &twl->xfer_msg[1]; msg = &twl->xfer_msg[1];
msg->addr = twl->address; msg->addr = twl->address;
msg->flags = I2C_M_RD; /* Read the register value */ msg->flags = I2C_M_RD; /* Read the register value */
msg->len = num_bytes; /* only n bytes */ msg->len = num_bytes; /* only n bytes */
msg->buf = value; msg->buf = value;
ret = i2c_transfer(twl->client.adapter, twl->xfer_msg, 1); ret = i2c_transfer(twl->client.adapter, twl->xfer_msg, 2);
out:
mutex_unlock(&twl->xfer_lock); mutex_unlock(&twl->xfer_lock);
/* i2cTransfer returns num messages.translate it pls.. */ /* i2cTransfer returns num messages.translate it pls.. */
if (ret >= 0) if (ret >= 0)
ret = 0; ret = 0;
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment