Commit 0287d970 authored by Wu Fengguang's avatar Wu Fengguang Committed by Takashi Iwai

intelhdmi - dont power off HDA link

For codecs without EPSS support (G45/IbexPeak), the hotplug event will
be lost if the HDA is powered off during the time. After that the pin
presence detection verb returns inaccurate info.

So always power-on HDA link for !EPSS codecs.

KarL offers the fact and Takashi recommends to flag hda_bus. Thanks!
Signed-off-by: default avatarWu Fengguang <fengguang.wu@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b14224bb
...@@ -639,6 +639,7 @@ struct hda_bus { ...@@ -639,6 +639,7 @@ struct hda_bus {
unsigned int rirb_error:1; /* error in codec communication */ unsigned int rirb_error:1; /* error in codec communication */
unsigned int response_reset:1; /* controller was reset */ unsigned int response_reset:1; /* controller was reset */
unsigned int in_reset:1; /* during reset operation */ unsigned int in_reset:1; /* during reset operation */
unsigned int power_keep_link_on:1; /* don't power off HDA link */
}; };
/* /*
......
...@@ -2082,7 +2082,8 @@ static void azx_power_notify(struct hda_bus *bus) ...@@ -2082,7 +2082,8 @@ static void azx_power_notify(struct hda_bus *bus)
} }
if (power_on) if (power_on)
azx_init_chip(chip); azx_init_chip(chip);
else if (chip->running && power_save_controller) else if (chip->running && power_save_controller &&
!bus->power_keep_link_on)
azx_stop_chip(chip); azx_stop_chip(chip);
} }
#endif /* CONFIG_SND_HDA_POWER_SAVE */ #endif /* CONFIG_SND_HDA_POWER_SAVE */
......
...@@ -391,6 +391,17 @@ static int intel_hdmi_parse_codec(struct hda_codec *codec) ...@@ -391,6 +391,17 @@ static int intel_hdmi_parse_codec(struct hda_codec *codec)
} }
} }
/*
* G45/IbexPeak don't support EPSS: the unsolicited pin hot plug event
* can be lost and presence sense verb will become inaccurate if the
* HDA link is powered off at hot plug or hw initialization time.
*/
#ifdef CONFIG_SND_HDA_POWER_SAVE
if (!(snd_hda_param_read(codec, codec->afg, AC_PAR_POWER_STATE) &
AC_PWRST_EPSS))
codec->bus->power_keep_link_on = 1;
#endif
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment