Commit 0188eb59 authored by Xiao Guangrong's avatar Xiao Guangrong Committed by Thomas Gleixner

perf_counter: Fix buffer overflow in perf_copy_attr()

If we pass a big size data over perf_counter_open() syscall,
the kernel will copy this data to a small buffer, it will
cause kernel crash.

This bug makes the kernel unsafe and non-root local user can
trigger it.
Signed-off-by: default avatarXiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
Acked-by: default avatarPaul Mackerras <paulus@samba.org>
Cc: <stable@kernel.org>
LKML-Reference: <4AAF37D4.5010706@cn.fujitsu.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent f7ada8bf
...@@ -4212,6 +4212,7 @@ static int perf_copy_attr(struct perf_counter_attr __user *uattr, ...@@ -4212,6 +4212,7 @@ static int perf_copy_attr(struct perf_counter_attr __user *uattr,
if (val) if (val)
goto err_size; goto err_size;
} }
size = sizeof(*attr);
} }
ret = copy_from_user(attr, uattr, size); ret = copy_from_user(attr, uattr, size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment