• Olga Kornievskaia's avatar
    nfsd: use static memory for callback program and stats · ff7d9756
    Olga Kornievskaia authored
    There's no need to dynamically allocate this memory, and doing so may
    create the possibility of races on shutdown of the rpc client.  (We've
    witnessed it only after adding rpcsec_gss support to the server, after
    which the rpc code can send destroys calls that expect to still be able
    to access the rpc_stats structure after it has been destroyed.)
    
    Such races are in theory possible if the module containing this "static"
    memory is removed very quickly after an rpc client is destroyed, but
    we haven't seen that happen.
    Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
    ff7d9756
nfs4callback.c 13.2 KB