• Linus Torvalds's avatar
    Check mapped ranges on sysfs resource files · fe261563
    Linus Torvalds authored
    commit b5ff7df3 upstream
    
    Check mapped ranges on sysfs resource files
    
    This is loosely based on a patch by Jesse Barnes to check the user-space
    PCI mappings though the sysfs interfaces.  Quoting Jesse's original
    explanation:
    
      It's fairly common for applications to map PCI resources through sysfs.
      However, with the current implementation, it's possible for an application
      to map far more than the range corresponding to the resourceN file it
      opened.  This patch plugs that hole by checking the range at mmap time,
      similar to what is done on platforms like sparc64 in their lower level
      PCI remapping routines.
    
      It was initially put together to help debug the e1000e NVRAM corruption
      problem, since we initially thought an X driver might be walking past the
      end of one of its mappings and clobbering the NVRAM.  It now looks like
      that's not the case, but doing the check is still important for obvious
      reasons.
    
    and this version of the patch differs in that it uses a helper function
    to clarify the code, and does all the checks in pages (instead of bytes)
    in order to avoid overflows when doing "<< PAGE_SHIFT" etc.
    
    [cebbert@redhat.com: backport, changing WARN() to printk()]
    Acked-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Cc: Chuck Ebbert <cebbert@redhat.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    fe261563
pci-sysfs.c 21.5 KB