• David S. Miller's avatar
    sparc64: Fix MM refcount check in smp_flush_tlb_pending(). · f9384d41
    David S. Miller authored
    As explained by Benjamin Herrenschmidt:
    
    > CPU 0 is running the context, task->mm == task->active_mm == your
    > context. The CPU is in userspace happily churning things.
    >
    > CPU 1 used to run it, not anymore, it's now running fancyfsd which
    > is a kernel thread, but current->active_mm still points to that
    > same context.
    >
    > Because there's only one "real" user, mm_users is 1 (but mm_count is
    > elevated, it's just that the presence on CPU 1 as active_mm has no
    > effect on mm_count().
    >
    > At this point, fancyfsd decides to invalidate a mapping currently mapped
    > by that context, for example because a networked file has changed
    > remotely or something like that, using unmap_mapping_ranges().
    >
    > So CPU 1 goes into the zapping code, which eventually ends up calling
    > flush_tlb_pending(). Your test will succeed, as current->active_mm is
    > indeed the target mm for the flush, and mm_users is indeed 1. So you
    > will -not- send an IPI to the other CPU, and CPU 0 will continue happily
    > accessing the pages that should have been unmapped.
    
    To fix this problem, check ->mm instead of ->active_mm, and this
    means:
    
    > So if you test current->mm, you effectively account for mm_users == 1,
    > so the only way the mm can be active on another processor is as a lazy
    > mm for a kernel thread. So your test should work properly as long
    > as you don't have a HW that will do speculative TLB reloads into the
    > TLB on that other CPU (and even if you do, you flush-on-switch-in should
    > get rid of any crap here).
    
    And therefore we should be OK.
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f9384d41
smp_64.c 32.6 KB