• Shaun Ruffell's avatar
    dma-debug: Do not add notifier when dma debugging is disabled. · f797d988
    Shaun Ruffell authored
    If CONFIG_HAVE_DMA_API_DEBUG is defined and "dma_debug=off" is
    specified on the kernel command line, when you detach a driver from a
    device you can cause the following NULL pointer dereference:
    
    BUG: unable to handle kernel NULL pointer dereference at (null)
    IP: [<c0580d35>] dma_debug_device_change+0x5d/0x117
    
    The problem is that the dma_debug_device_change notifier function is
    added to the bus notifier chain even though the dma_entry_hash array
    was never initialized.  If dma debugging is disabled, this patch both
    prevents dma_debug_device_change notifiers from being added to the
    chain, and additionally ensures that the dma_debug_device_change
    notifier function is a no-op.
    
    Cc: stable@kernel.org
    Signed-off-by: default avatarShaun Ruffell <sruffell@digium.com>
    Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
    f797d988
dma-debug.c 31.5 KB