• Enrico Scholz's avatar
    [ARM] 4403/1: Make the PXA-I2C driver work with lockdep validator · 6776f3d2
    Enrico Scholz authored
    Using lockdep validator causes warnings like
    
      INFO: trying to register non-static key.
      the code is fine but needs lockdep annotation.
      turning off the locking correctness validator.
      [<c00241a0>] (dump_stack+0x0/0x14) from [<c00520f8>] (__lock_acquire+0x150/0xc40)
      [<c0051fa8>] (__lock_acquire+0x0/0xc40) from [<c00530a0>] (lock_acquire+0x5c/0x70)
      [<c0053044>] (lock_acquire+0x0/0x70) from [<c01d9e44>] (_spin_lock_irq+0x48/0x58)
       r7:c07e5144 r6:00000000 r5:c015fb94 r4:c07e50b8
      [<c01d9dfc>] (_spin_lock_irq+0x0/0x58) from [<c015fb94>] (i2c_pxa_xfer+0x110/0x2e0)
       r5:c07e50b8 r4:0000001f
    
    This is caused by memcpy'ing a statical initialized spin-lock. This patch
    removes a static pxa_i2c structure which was used only as a source for this
    memcpy() operation. Instead of, members and the spinlock will be
    initialized manually.
    Signed-off-by: default avatarEnrico Scholz <enrico.scholz@sigma-chemnitz.de>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    6776f3d2
i2c-pxa.c 22.1 KB