• Juergen Beisert's avatar
    x86: Replace NSC/Cyrix specific chipset access macros by inlined functions. · f25f64ed
    Juergen Beisert authored
    Due to index register access ordering problems, when using macros a line
    like this fails (and does nothing):
    
    	setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88);
    
    With inlined functions this line will work as expected.
    
    Note about a side effect: Seems on Geode GX1 based systems the
    "suspend on halt power saving feature" was never enabled due to this
    wrong macro expansion. With inlined functions it will be enabled, but
    this will stop the TSC when the CPU runs into a HLT instruction.
    Kernel output something like this:
    	Clocksource tsc unstable (delta = -472746897 ns)
    
    This is the 3rd version of this patch.
    
     - Adding missed arch/i386/kernel/cpu/mtrr/state.c
    	Thanks to Andres Salomon
     - Adding some big fat comments into the new header file
     	Suggested by Andi Kleen
    
    AK: fixed x86-64 compilation
    Signed-off-by: default avatarJuergen Beisert <juergen@kreuzholzen.de>
    Signed-off-by: default avatarAndi Kleen <ak@suse.de>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f25f64ed
gx-suspmod.c 14.6 KB