• Stefan Richter's avatar
    firewire: fw-ohci: enforce read order for selfID generation · ee71c2f9
    Stefan Richter authored
    It seems unlikely, but access to self_id_cpu[0] could at least in theory
    be deferred until after the loop over self_id_cpu[1..n] or even after
    the subsequent reg_read.  Enforce the desired order by a read barrier.
    
    Also prevent the reg_read from being reordered relative to the for loop.
    This isn't necessary if the loop's conditional printk counts as an
    implicit barrier, but better make it explicit.
    
    (self_id_cpu[] is a coherent DMA buffer.)
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    ee71c2f9
fw-ohci.c 53.9 KB