• Bartlomiej Zolnierkiewicz's avatar
    nfs: remove superfluous BUG_ON()s · e576e05a
    Bartlomiej Zolnierkiewicz authored
    Subject: [PATCH] nfs: remove superfluous BUG_ON()s
    
    Remove duplicated BUG_ON()s from nfs[4]_create_server()
    (we make the same checks earlier in both functions).
    
    This takes care of the following entries from Dan's list:
    
    fs/nfs/client.c +1078 nfs_create_server(47) warning: variable derefenced before check 'server->nfs_client'
    fs/nfs/client.c +1079 nfs_create_server(48) warning: variable derefenced before check 'server->nfs_client->rpc_ops'
    fs/nfs/client.c +1363 nfs4_create_server(43) warning: variable derefenced before check 'server->nfs_client'
    fs/nfs/client.c +1364 nfs4_create_server(44) warning: variable derefenced before check 'server->nfs_
    Reported-by: default avatarDan Carpenter <error27@gmail.com>
    Cc: corbet@lwn.net
    Cc: eteo@redhat.com
    Cc: Julia Lawall <julia@diku.dk>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    e576e05a
client.c 44.1 KB