• Tejun Heo's avatar
    percpu: restructure pcpu_extend_area_map() to fix bugs and improve readability · 833af842
    Tejun Heo authored
    pcpu_extend_area_map() had the following two bugs.
    
    * It should return 1 if pcpu_lock was dropped and reacquired but it
      returned 0.  This could lead to oops if free_percpu() races with
      area map extension.
    
    * pcpu_mem_free() was called under pcpu_lock.  pcpu_mem_free() might
      end up calling vfree() which isn't IRQ safe.  This could lead to
      deadlock through lock order inversion via IRQ.
    
    In addition, Linus pointed out that the temporary lock dropping and
    subtle three-way return value of pcpu_extend_area_map() was very ugly
    and suggested to split the function into two - pcpu_need_to_extend()
    and pcpu_extend_area_map().
    
    This patch restructures pcpu_extend_area_map() as suggested and fixes
    the two bugs.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Acked-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    833af842
percpu.c 62 KB