• Amerigo Wang's avatar
    [CPUFREQ] fix a lockdep warning · 499bca9b
    Amerigo Wang authored
    There is no need to do sysfs_remove_link() or kobject_put() etc.
    when policy_rwsem_write is held, move them after releasing the lock.
    
    This fixes the lockdep warning:
    
    halt/4071 is trying to acquire lock:
     (s_active){++++.+}, at: [<c0000000001ef868>] .sysfs_addrm_finish+0x58/0xc0
    
    but task is already holding lock:
     (&per_cpu(cpu_policy_rwsem, cpu)){+.+.+.}, at: [<c0000000004cd6ac>] .lock_policy_rwsem_write+0x84/0xf4
    Reported-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: default avatarWANG Cong <amwang@redhat.com>
    Cc: Johannes Berg <johannes@sipsolutions.net>
    Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
    Signed-off-by: default avatarDave Jones <davej@redhat.com>
    499bca9b
cpufreq.c 50.9 KB