• Stefan Richter's avatar
    ieee1394: ignore nonzero Bus_Info_Block.max_rom, fetch config ROM in quadlets · 0bed1819
    Stefan Richter authored
    It is already known that buggy firmwares exist which report a bogus
    link_spd in their config ROM bus info block.  We now got the first
    report of a bogus max_rom too (Freecom FireWire Hard Drive 1TB,
    http://bugzilla.kernel.org/show_bug.cgi?id=12206).
    
    I suspect other OSs only use quadlet reads to fetch the config ROM,
    otherwise the firmware authors would have noticed their mistake.
    Hence limit ieee1394's config ROM fetching routine to quadlets as the
    safe minimum regardless of what the bus info block says.
    
    This will potentially slow the bus reset handling by nodemgr somewhat
    down.  But most existing devices support only quadlet reads anyway,
    hence there will often be no actual difference to before this change.
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    0bed1819
nodemgr.c 51.2 KB