• Will Newton's avatar
    8250: improve workaround for UARTs that don't re-assert THRE correctly · da924e49
    Will Newton authored
    commit 363f66fe upstream
    
    Recent changes to tighten the check for UARTs that don't correctly
    re-assert THRE (01c194d9: "serial 8250:
    tighten test for using backup timer") caused problems when such a UART was
    opened for the second time - the bug could only successfully be detected
    at first initialization.  For users of this version of this particular
    UART IP it is fatal.
    
    This patch stores the information about the bug in the bugs field of the
    port structure when the port is first started up so subsequent opens can
    check this bit even if the test for the bug fails.
    
    David Brownell: "My own exposure to this is that the UART on DaVinci
    hardware, which TI allegedly derived from its original 16550 logic, has
    periodically gone from working to unusable with the mainline 8250.c ...
    and back and forth a bunch.  Currently it's "unusable", a regression from
    some previous versions.  With this patch from Will, it's usable."
    Signed-off-by: default avatarWill Newton <will.newton@gmail.com>
    Acked-by: default avatarAlex Williamson <alex.williamson@hp.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: David Brownell <david-b@pacbell.net>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    da924e49
8250.c 75 KB