• Krzysztof Helt's avatar
    [SCSI] sym53c8xx: fixes two bugs related to chip reset · d9aa3af0
    Krzysztof Helt authored
    This patch fixes two bugs pointed by James Bottomley:
    
     1. the if (!sym_data->io_reset).  That variable is only ever filled
        by a stack based completion.  If we find it non empty it means
        this code has been entered twice and we have a severe problem,
        so that should just become a BUG_ON(sym_data->io_reset).
     2. sym_data->io_reset should be set to NULL before the routine is
        exited otherwise the PCI recovery code could end up completing
        what will be a bogus pointer into the stack.
    
    Big thanks to James Bottomley for help with the patch.
    Signed-off-by: default avatarKrzysztof Helt <krzysztof.h1@w.pl>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
    d9aa3af0
sym_glue.c 52.6 KB