• Hugh Dickins's avatar
    shmem_getpage return page locked · d3602444
    Hugh Dickins authored
    In the new aops, write_begin is supposed to return the page locked: though
    I've seen no ill effects, that's been overlooked in the case of
    shmem_write_begin, and should be fixed.  Then shmem_write_end must unlock the
    page: do so _after_ updating i_size, as we found to be important in other
    filesystems (though since shmem pages don't go the usual writeback route, they
    never suffered from that corruption).
    
    For shmem_write_begin to return the page locked, we need shmem_getpage to
    return the page locked in SGP_WRITE case as well as SGP_CACHE case: let's
    simplify the interface and return it locked even when SGP_READ.
    Signed-off-by: default avatarHugh Dickins <hugh@veritas.com>
    Acked-by: default avatarRik van Riel <riel@redhat.com>
    Cc: Nick Piggin <nickpiggin@yahoo.com.au>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    d3602444
shmem.c 64.6 KB