• Ed Swierk's avatar
    forcedeth: power down phy when interface is down · cb52deba
    Ed Swierk authored
    Bring the physical link down when the interface is down by placing the PHY
    in power-down state, unless WOL is enabled.  This mirrors the behavior of
    other drivers including e1000 and tg3.
    
    Without the patch, ifconfig down leaves the physical link up, which confuses
    datacenter users who expect the link lights both on the NIC and the switch to
    go out when they bring an interface down.
    
    Furthermore, even though the phy is powered on, autonegotiation stops working,
    so a normally gigabit link might suddenly become 100 Mbit half-duplex when the
    interface goes down, and become gigabit when it comes up again.
    
    Ayaz said:
    
      I would not include this patch until further testing is performed.  NVIDIA
      MCP chips use 3rd party PHY vendors.  By powering down the phy, it could
      have adverse affects on certain phys.
    
    Arthur Jones said:
    
      I just ran across this patch.  Tested on a Marvell 88E1121R (GigE PHY)
      and works great.  This is a very important feature for me.
    Signed-off-by: default avatarEd Swierk <eswierk@arastra.com>
    Tested-by: default avatarArthur Jones <ajones@riverbed.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    cb52deba
forcedeth.c 190 KB