• Michael Halcrow's avatar
    eCryptfs: remove unnecessary BUG_ON · c59c2eb5
    Michael Halcrow authored
    Andrew Morton wrote:
    > > +     mutex_lock(&mount_crypt_stat->global_auth_tok_list_mutex);
    > > +     BUG_ON(mount_crypt_stat->num_global_auth_toks == 0);
    > > +     mutex_unlock(&mount_crypt_stat->global_auth_tok_list_mutex);
    >
    > That's odd-looking.  If it was a bug for num_global_auth_toks to be
    > zero, and if that mutex protects num_global_auth_toks then as soon
    > as the lock gets dropped, another thread can make
    > num_global_auth_toks zero, hence the bug is present.  Perhaps?
    
    That was serving as an internal sanity check that should not have made
    it into the final patch set in the first place. This patch removes it.
    Signed-off-by: default avatarMichael Halcrow <mhalcrow@us.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    c59c2eb5
crypto.c 57.7 KB