• Ajit Khaparde's avatar
    net: bug fix for vlan + gro issue · c4d49794
    Ajit Khaparde authored
    Traffic (tcp) doesnot start on a vlan interface when gro is enabled.
    Even the tcp handshake was not taking place.
    This is because, the eth_type_trans call before the netif_receive_skb
    in napi_gro_finish() resets the skb->dev to napi->dev from the previously
    set vlan netdev interface. This causes the ip_route_input to drop the
    incoming packet considering it as a packet coming from a martian source.
    
    I could repro this on 2.6.32.7 (stable) and 2.6.33-rc7.
    With this fix, the traffic starts and the test runs fine on both vlan
    and non-vlan interfaces.
    
    CC: Herbert Xu <herbert@gondor.apana.org.au>
    CC: Patrick McHardy <kaber@trash.net>
    Signed-off-by: default avatarAjit Khaparde <ajitk@serverengines.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c4d49794
dev.c 143 KB