• Andres Salomon's avatar
    x86: GEODE: update GPIO API to support setting multiple GPIOs at once · ade76149
    Andres Salomon authored
    The existing Geode GPIO API only allows for updating one GPIO at once.  There
    are instances where users want to update multiple GPIOs at once.  With the
    current API, they are given two choices; either ignore the GPIO API:
    
          outl(0xc000, gpio_base + GPIO_OUTPUT_VAL);
          outl(0xc000, gpio_base + GPIO_OUTPUT_ENABLE);
    
    Alternatively, call each GPIO update separately:
    
          geode_gpio_set(14, GPIO_OUTPUT_VAL);
          geode_gpio_set(15, GPIO_OUTPUT_VAL);
          geode_gpio_set(14, GPIO_OUTPUT_ENABLE);
          geode_gpio_set(15, GPIO_OUTPUT_ENABLE);
    
    Neither are desirable.  This patch changes the GPIO API to allow for setting
    of multiple GPIOs at once; rather than being passed an integer, we pass
    a bitmask and provide a translation function.  The above code would now
    look like this:
    
          geode_gpio_set(geode_gpio(14)|geode_gpio(15), GPIO_OUTPUT_VAL);
          geode_gpio_set(geode_gpio(14)|geode_gpio(15), GPIO_OUTPUT_ENABLE);
    
    Since there are no upstream users of the GPIO API yet (afaik), best to
    change this now.  This also adds a bit of sanity checking; it is no
    longer possible to use a GPIO above 28.
    
    Note the semantics of geode_gpio_isset() have changed:
    geode_gpio_isset(geode_gpio(3)|geode_gpio(4), ...)
    will only return true iff both GPIOs are set.
    Signed-off-by: default avatarAndres Salomon <dilinger@debian.org>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    ade76149
geode.h 5.4 KB