• Anton Vorontsov's avatar
    sdhci-of: cleanup eSDHC's set_clock() a little bit · ad1e597d
    Anton Vorontsov authored
    - Get rid of incomprehensible "if { for { if } }" construction for the
      exponential divisor calculation. The first if statement isn't correct
      at all, since it should check for "host->max_clk / pre_div / 16 >
      clock". The error doesn't cause any bugs because the check in the for
      loop does the right thing, and so the outer check becomes useless;
    
    - For the linear divisor do the same: a single while statement is more
      readable than for + if construction;
    
    - Add dev_dbg() that prints desired and actual clock frequency.
    Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
    Cc: Pierre Ossman <pierre@ossman.eu>
    Cc: Kumar Gala <galak@kernel.crashing.org>
    Cc: David Vrabel <david.vrabel@csr.com>
    Cc: Ben Dooks <ben@fluff.org>
    Cc: Sascha Hauer <s.hauer@pengutronix.de>
    Cc: <linux-mmc@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ad1e597d
sdhci-of.c 8 KB