• Patrick McHardy's avatar
    Fix SET_VLAN_INGRESS_PRIORITY_CMD error return. · 9def747b
    Patrick McHardy authored
    patch fffe470a in mainline.
    
    [VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl
    
    Based on report and patch by Doug Kehn <rdkehn@yahoo.com>:
    
    vconfig returns the following error when attempting to execute the
    set_ingress_map command:
    
    vconfig: socket or ioctl error for set_ingress_map: Operation not permitted
    
    In vlan.c, vlan_ioctl_handler for SET_VLAN_INGRESS_PRIORITY_CMD
    sets err = -EPERM and calls vlan_dev_set_ingress_priority.
    vlan_dev_set_ingress_priority is a void function so err remains
    at -EPERM and results in the vconfig error (even though the ingress
    map was set).
    
    Fix by setting err = 0 after the vlan_dev_set_ingress_priority call.
    Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    9def747b
vlan.c 20.5 KB