• Krishna Kumar's avatar
    genetlink: Optimize and one bug fix in genl_generate_id() · 988ade6b
    Krishna Kumar authored
    1. GENL_MIN_ID is a valid id -> no need to start at
       GENL_MIN_ID + 1.
    2. Avoid going through the ids two times: If we start at
       GENL_MIN_ID+1 (*or bigger*) and all ids are over!, the
       code iterates through the list twice (*or lesser*).
    3. Simplify code - no need to start at idx=0 which gets
       reset to GENL_MIN_ID.
    
    Patch on net-next-2.6. Reboot test shows that first id
    passed to genl_register_family was 16, next two were
    GENL_ID_GENERATE and genl_generate_id returned 17 & 18
    (user level testing of same code shows expected values
    across entire range of MIN/MAX).
    Signed-off-by: default avatarKrishna Kumar <krkumar2@in.ibm.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    988ade6b
genetlink.c 21.3 KB