• Arjan van de Ven's avatar
    gcc is not convinced that the floppy.c ioctl has sufficient bound checks: · 8c262146
    Arjan van de Ven authored
    In function `copy_from_user',
        inlined from `fd_copyin' at drivers/block/floppy.c:3080,
        inlined from `fd_ioctl' at drivers/block/floppy.c:3503:
    /home/arjan/linux/arch/x86/include/asm/uaccess_32.h:211:
    warning: call to `copy_from_user_overflow' declared with attribute
    warning: copy_from_user buffer size is not provably correct
    
    And frankly, as a human I have a hard time proving the same more or less
    (the size comes from the ioctl argument.  humpf.  maybe.  the code isn't
    very nice)
    
    This patch adds an explicit check to make 100% sure it's safe, better than
    finding out later that there indeed was a gap.
    Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    8c262146
floppy.c 118 KB