• Trent Piepho's avatar
    V4L/DVB (6508): ttpci: Rework Kconfig menus and Makefile · 8ae1fe2a
    Trent Piepho authored
    The ttpci Kconfig file has bugs that cause it to fail in certain Kconfig
    situations.  The basic problem is that it selects certain drivers, but does
    not depend on the dependencies of those drivers.
    
    See http://article.gmane.org/gmane.comp.video.video4linux/35072
    
    Using the Kconfig file also has some annoyances.  For instance one can't turn
    off AV7110 support unless you go down several options and first turn off
    budget-patch support.  Normally user selectable drivers are not forced on like
    this.
    
    The "AV7110 cards with Budget Patch" option is disabled if "Budget cards"
    isn't on.  Normally a driver appears nested under a driver it depends on, but
    since drivers that don't depend on "Budget cards" are between the two options,
    the config programs can't display the tree correctly.
    
    The Makefile has an issue too.  Some modules, ttpci-eeprom and budget-core,
    appear in the Makefile under several different config symbols.  If more than
    one of these symbols is on, they will get added the to list of objects
    multiple times.  The normal convention is to have a config symbol just the
    common object(s) and have the users of the that object either depend on or
    select that config symbol.
    
    This patch fixes all these issues.  ttpci-eepom is under a new config symbol,
    and so is the budget-core module.  The four different budget card types appear
    as sub-drivers under a main "SAA7146 DVB cards" option.  Turning on
    budget-patch doesn't force AV7110.  Drivers using SAA7146_VV have the
    necessary VIDEO_DEV dependency, so that it isn't possible to select SAA7146_VV
    without V4L being on.
    Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
    8ae1fe2a
Kconfig 5.49 KB