• Julia Lawall's avatar
    powerpc/85xx: Add local_irq_restore in error handling code · 870029a6
    Julia Lawall authored
    There is a call to local_irq_restore in the normal exit case, so it would
    seem that there should be one on an error return as well.
    
    The semantic patch that makes this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)
    
    // <smpl>
    @@
    expression l;
    expression E,E1,E2;
    @@
    
    local_irq_save(l);
    ... when != local_irq_restore(l)
        when != spin_unlock_irqrestore(E,l)
        when any
        when strict
    (
    if (...) { ... when != local_irq_restore(l)
                   when != spin_unlock_irqrestore(E1,l)
    +   local_irq_restore(l);
        return ...;
    }
    |
    if (...)
    +   {local_irq_restore(l);
        return ...;
    +   }
    |
    spin_unlock_irqrestore(E2,l);
    |
    local_irq_restore(l);
    )
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
    870029a6
smp.c 2.44 KB