• Rusty Russell's avatar
    virtio: handle interrupts after callbacks turned off · 81a8deab
    Rusty Russell authored
    Anthony Liguori found double interrupt suppression in the virtio_net
    driver, triggered by two skb_recv_done's in a row.  This is because
    virtio_ring's interrupt suppression is a best-effort optimization: it
    contains no synchronization so the host can miss it and still send
    interrupts.
    
    But it's certainly nicer for virtio users if calling disable_cb
    actually disables callbacks, so we check for the race in the interrupt
    routine.
    
    Note: SMP guests might require syncronization here, but since
    disable_cb is actually called from interrupt context, there has to be
    some form of synchronization before the next same interrupt handler is
    called (Linux guarantees that the same device's irq handler will never
    run simultanously on multiple CPUs).
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    81a8deab
virtio_ring.c 8.11 KB