• Xiaotian Feng's avatar
    selinux: fix memory leak in sel_make_bools · 8007f102
    Xiaotian Feng authored
    In sel_make_bools, kernel allocates memory for bool_pending_names[i]
    with security_get_bools. So if we just free bool_pending_names, those
    memories for bool_pending_names[i] will be leaked.
    
    This patch resolves dozens of following kmemleak report after resuming
    from suspend:
    unreferenced object 0xffff88022e4c7380 (size 32):
      comm "init", pid 1, jiffies 4294677173
      backtrace:
        [<ffffffff810f76b5>] create_object+0x1a2/0x2a9
        [<ffffffff810f78bb>] kmemleak_alloc+0x26/0x4b
        [<ffffffff810ef3eb>] __kmalloc+0x18f/0x1b8
        [<ffffffff811cd511>] security_get_bools+0xd7/0x16f
        [<ffffffff811c48c0>] sel_write_load+0x12e/0x62b
        [<ffffffff810f9a39>] vfs_write+0xae/0x10b
        [<ffffffff810f9b56>] sys_write+0x4a/0x6e
        [<ffffffff81011b82>] system_call_fastpath+0x16/0x1b
        [<ffffffffffffffff>] 0xffffffffffffffff
    Signed-off-by: default avatarXiaotian Feng <dfeng@redhat.com>
    Signed-off-by: default avatarJames Morris <jmorris@namei.org>
    8007f102
selinuxfs.c 37.8 KB