• Suresh Siddha's avatar
    x86, irq: Check move_in_progress before freeing the vector mapping · 7f41c2e1
    Suresh Siddha authored
    With the recent irq migration fixes (post 2.6.32), Gary Hade has noticed
    "No IRQ handler for vector" messages during the 2.6.33-rc1 kernel boot on IBM
    AMD platforms and root caused the issue to this commit:
    
    > commit 23359a88
    > Author: Suresh Siddha <suresh.b.siddha@intel.com>
    > Date:   Mon Oct 26 14:24:33 2009 -0800
    >
    >    x86: Remove move_cleanup_count from irq_cfg
    
    As part of this patch, we have removed the move_cleanup_count check
    in smp_irq_move_cleanup_interrupt(). With this change, we can run into a
    situation where an irq cleanup interrupt on a cpu can cleanup the vector
    mappings associated with multiple irqs, of which one of the irq's migration
    might be still in progress. As such when that irq hits the old cpu, we get
    the "No IRQ handler" messages.
    
    Fix this by checking for the irq_cfg's move_in_progress and if the move
    is still in progress delay the vector cleanup to another irq cleanup
    interrupt request (which will happen when the irq starts arriving at the
    new cpu destination).
    Reported-and-tested-by: default avatarGary Hade <garyhade@us.ibm.com>
    Signed-off-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
    LKML-Reference: <1262804191.2732.7.camel@sbs-t61.sc.intel.com>
    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
    7f41c2e1
io_apic.c 102 KB