• Ralf Baechle's avatar
    [MIPS] time: Delete weak definition of plat_time_init() due to gcc bug. · 4037500e
    Ralf Baechle authored
    Frank Rowand <frank.rowand@am.sony.com> reports:
    
    > In linux-2.6.24-rc4 the Toshiba RBTX4927 hangs on boot.
    >
    > The cause is that plat_time_init() from arch/mips/tx4927/common/
    > tx4927_setup.c does not override the __weak plat_time_init() from
    > arch/mips/kernel/time.c.  This is due to a compiler bug in gcc 4.1.1.  The
    > bug is reported to not exist in earlier versions of gcc, and to be fixed in
    > 4.1.2.  The problem is that the __weak plat_time_init() is empty and thus
    > gets optimized out of existence (thus the linker is never given the option
    > to replace the __weak function).
    
    [ He meant the call to plat_time_init() from time_init() gets optimized away ]
    
    > For more info on the gcc bug see
    >
    >    http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781
    >
    > The attached patch is one workaround.  Another possible workaround
    
    [ His patch adds -fno-unit-at-a-time for time.c ]
    
    > would be to change the __weak plat_time_init() to be a non-empty
    > function.
    
    The __weak definition of plat_time_init was only ever meant to be a
    migration helper to keep platforms that don't have a plat_time_init
    compiling.  A few greps says that all platforms now supply their own
    plat_time_init() so the weak definition is no longer needed.  So I
    instead delete it.
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    4037500e
time.c 3.64 KB