• David Gibson's avatar
    [PATCH] FUTEX_WAKE_OP: enhanced error handling · 796f8d9b
    David Gibson authored
    The code for FUTEX_WAKE_OP calls an arch callback,
    futex_atomic_op_inuser().  That callback can return an error code, but
    currently the caller assumes any error is EFAULT, and will try various
    things to resolve the fault before eventually giving up with EFAULT
    (regardless of the original error code).  This is not a theoretical case -
    arch callbacks currently return -ENOSYS if the opcode they are given is
    bogus.
    
    This patch alters the code to detect non-EFAULT errors and return them
    directly to the user.
    
    Of course, whether -ENOSYS is the correct return value for the bogus opcode
    case, or whether EINVAL would be more appropriate is another question.
    Signed-off-by: default avatarDavid Gibson <dwg@au1.ibm.com>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Jamie Lokier <jamie@shareable.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    796f8d9b
futex.c 21.7 KB