• Paul Mackerras's avatar
    perf_counter: powerpc: Fix event alternative code generation on POWER5/5+ · 6984efb6
    Paul Mackerras authored
    Commit ef923214 ("perf_counter: powerpc: use u64 for event
    codes internally") introduced a bug where the return value from
    function find_alternative_bdecode gets put into a u64 variable
    and later tested to see if it is < 0.  The effect is that we
    get extra, bogus event code alternatives on POWER5 and POWER5+,
    leading to error messages such as "oops compute_mmcr failed"
    being printed and counters not counting properly.
    
    This fixes it by using s64 for the return type of
    find_alternative_bdecode and for the local variable that the
    caller puts the value in.  It also makes the event argument a
    u64 on POWER5+ for consistency.
    Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: Marcelo Tosatti <mtosatti@redhat.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: John Kacur <jkacur@redhat.com>
    Cc: Stephane Eranian <eranian@googlemail.com>
    LKML-Reference: <18982.17586.666132.90983@cargo.ozlabs.ibm.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    6984efb6
power5-pmu.c 14.8 KB