• Trent Piepho's avatar
    V4L/DVB (6042): b2c2-flexcop: fix Airstar HD5000 tuning regression · 6175e487
    Trent Piepho authored
    Git changeset 6bdcc6e6 dropped the
    stand-alone lgh06xf module, whose functionality was absorbed into the
    dvb-pll module. However, there was a minor difference between the code
    in lgh06xf and dvb-pll, which caused a regression in b2c2-flexcop
    devices using the LG-H06xF NIM.
    
    dvb-pll will probe for the presence of an i2c pll chip by performing a
    single byte read, the lgh06xf driver did not do this. Unfortunately, the
    code in flexcop-i2c.c does not currently support 1 byte or 0 byte reads
    as a probe.  Such probes with the current code will always fail.
    
    In order to work around this problem, and restore proper functionality
    of the Airstar HD5000 device, this hack was created to make the probe
    appear to succeed.  The single byte read in dvb_pll_attach is the only
    place where such a probe would ever occur, so this change is safe, and
    will not affect any other devices.
    
    Of course, if one knew how to actually perform the read operation, it
    would be better to go that route.  In the meantime, however, we must
    apply this workaround, in order to prevent the regression that causes
    tuning to fail on the Airstar HD5000 ATSC device.
    
    Thanks to Jarod Wilson, who had originally reported this regression, and
    to Geoffrey Hausheer, whose original workaround patch led us to find the
    actual cause of the problem.
    Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
    Cc: Geoffrey Hausheer <inli3epy93n@phracturedblue.com>
    Acked-by: default avatarJarod Wilson <jwilson@redhat.com>
    Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
    6175e487
flexcop-i2c.c 5.66 KB