• Oleg Nesterov's avatar
    coredump: set ->group_exit_code for other CLONE_VM tasks too · 5c99cbf4
    Oleg Nesterov authored
    User visible change.
    
    do_coredump() kills all threads which share the same ->mm but only the
    coredumping process gets the proper exit_code.  Other tasks which share
    the same ->mm die "silently" and return status == 0 to parent.
    
    This is historical behaviour, not actually a bug.  But I think Frank
    Heckenbach rightly dislikes the current behaviour.  Simple test-case:
    
    	#include <stdio.h>
    	#include <unistd.h>
    	#include <signal.h>
    	#include <sys/wait.h>
    
    	int main(void)
    	{
    		int stat;
    
    		if (!fork()) {
    			if (!vfork())
    				kill(getpid(), SIGQUIT);
    		}
    
    		wait(&stat);
    		printf("stat=%x\n", stat);
    		return 0;
    	}
    
    Before this patch it prints "stat=0" despite the fact the child was killed
    by SIGQUIT.  After this patch the output is "stat=3" which obviously makes
    more sense.
    
    Even with this patch, only the task which originates the coredumping gets
    "|= 0x80" if the core was actually dumped, but at least the coredumping
    signal is visible to do_wait/etc.
    Reported-by: default avatarFrank Heckenbach <f.heckenbach@fh-soft.de>
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Acked-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
    Cc: Roland McGrath <roland@redhat.com>
    Cc: Neil Horman <nhorman@tuxdriver.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    5c99cbf4
exec.c 45.5 KB