• NeilBrown's avatar
    [PATCH] knfsd: nfsd: nfsd_setuser doesn't really need to modify rqstp->rq_cred. · 54cceebb
    NeilBrown authored
    In addition to setting the processes filesystem id's, nfsd_setuser also
    modifies the value of the rq_cred which stores the id's that originally came
    from the rpc call, for example to reflect root squashing.
    
    There's no real reason to do that--the only case where rqstp->rq_cred is
    actually used later on is in the NFSv4 SETCLIENTID/SETCLIENTID_CONFIRM
    operations, and there the results are the opposite of what we want--those two
    operations don't deal with the filesystem at all, they only record the
    credentials used with the rpc call for later reference (so that we may require
    the same credentials be used on later operations), and the credentials
    shouldn't vary just because there was or wasn't a previous operation in the
    compound that referred to some export
    
    This fixes a bug which caused mounts from Solaris clients to fail.
    Signed-off-by: default avatarAndy Adamson <andros@citi.umich.edu>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
    Signed-off-by: default avatarNeil Brown <neilb@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    54cceebb
auth.c 1.6 KB