• Lars Gjesse Kjellberg's avatar
    V4L/DVB (4681): Cx88: fix analog capture notch filter · 4f43ac0c
    Lars Gjesse Kjellberg authored
    This patch changes the setting of the cx2388x notch filter to match that of
    the video capture sample frequency, removing some annoying interference
    lines THAT would appear when capturing composite video. This has been tested
    in PAL and NTSC TV norms.
    It sets the Y/C separation luma notch filter, which removes the chroma signal
    from the luma signal when using a composite input.
    The luma notch filter operates at the video decoder's frequency, not the ADC's
    frequency or at the frequency of the scaled video. Y/C separation happens after
    the sample rate converter, before video scaling.
    The datasheet provides plots of the filter response for three _video decoder_
    frequencies, 4x Fsc, square pixel, and ccir601.  These are the same three
    frequencies for the notch filter control.  It seems pretty clear that this
    filter should be set based on the video decoder frequency. The cx88 driver
    always uses a video decoder frequency of 4xFsc. 
    Signed-off-by: default avatarLars Gjesse Kjellberg <lars.g.kjellberg@get2net.dk>
    Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
    Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
    4f43ac0c
cx88-core.c 32.6 KB