• David Woodhouse's avatar
    [PATCH] SCX200_ACB: eliminate spurious timeout errors · 3e3183ba
    David Woodhouse authored
    While busy-waiting for completion, check the hardware after scheduling;
    don't schedule and then immediately check the _timeout_.  If the yield()
    took a long time (as it does on my OLPC prototype board when it's busy),
    we'd report a timeout even though the hardware was now ready.
    
    This fixes it, and also switches the yield() for a cond_resched() because
    we don't actually want to be _that_ nice about it.  I see nice
    tightly-packed SMBus transactions now, rather than waiting for milliseconds
    between successive phases.
    
    Actually, we shouldn't be busy-waiting here at all.  We should be using
    interrupts.  That's an exercise for another day though.
    Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
    Cc: Christer Weinigel <wingel@nano-system.com>
    Cc: <Jordan.Crouse@amd.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    3e3183ba
scx200_acb.c 14.3 KB