• Trent Piepho's avatar
    V4L/DVB (5808): Bttv: fix v4l1 breaking the driver · 333408f2
    Trent Piepho authored
    If one uses a V4L *one* application, such as vlc or mplayer's v4l driver, as
    the first user after the driver is loaded, the driver wedges itself and will
    never capture properly.  Even if one uses a V4L2 application later, it still
    won't work.
    
    If one uses a V4L *two* application first, such as tvtime or mplayer's v4l2
    driver, then the driver will be ok.  One can then run a V4L1 application, and
    it will work.
    
    It turns out the problem is with norm changing and the crop support that was
    added in 2.6.21.  The driver defaults to PAL, and keeps the last norm it was
    set too across opens.  If one changes the norm via V4L1, the cropping
    parameters are not reset like they should be, and they'll remain broken across
    device opens.
    
    This patch removes the direct setting of btv->tvnorm in the V4L1 ioctl
    VIDIOCSCHAN handler.  The norm is set via the existing call to set_input(),
    which calls set_tvnorm(), which will reset the cropping values now that it is
    able to detect the norm change.
    Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
    Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
    333408f2
bttv-driver.c 127 KB