• Abhay Salunke's avatar
    [PATCH] dell_rbu: fix Bug 5854 · 2c560840
    Abhay Salunke authored
    This fixes http://bugzilla.kernel.org/show_bug.cgi?id=5854
    
    Root cause:
    
    The dell_rbu driver creates entries in /sys/class/firmware/dell_rbu/ by
    calling request_firmware_nowait (without hotplug ) this function inturn
    starts a kernel thread which creates the entries in
    /sys/class/firmware/dell_rbu/loading , data and the thread waits on the
    user action to return control back to the callback fucntion of dell_rbu.
    The thread calls wait_on_completion which puts it in a D state until the
    user action happens.  If there is no user action happening the load average
    goes up as the thread D state is taken in to account.  Also after
    downloading the BIOS image the enrties go away momentarily but they are
    recreated from the callback function in dell_rbu.  This causes the thread
    to get recreated causing the load average to permenently stay around 1.
    
    Fix:
    
    The dell_rbu also creates the entry
    /sys/devices/platform/dell_rbu/image_type at driver load time.  The image
    type by default is mono if required the user can echo packet to image_type
    to make the BIOS update mechanism using packets.  Also by echoing init in
    to image_type the /sys/class/firmware/dell_rbu entries can be created.
    
    The driver code was changed to not create /sys/class/firmware/dell_rbu
    entries during load time, and also to not create the above entries from the
    callback function.  The entries are only created by echoing init to
    /sys/devices/platform/dell_rbu/image_type The user now needs to create the
    entries to download the image monolithic or packet.  This fixes the issue
    since the kernel thread only is created when ever the user is ready to
    download the BIOS image; this minimizes the life span of the kernel thread
    and the load average goes back to normal.
    
    Signed off by Abhay Salunke <abhay_salunke@dell.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    2c560840
dell_rbu.c 18.9 KB