• Tejun Heo's avatar
    sysfs: cosmetic clean up on node creation failure paths · 967e35dc
    Tejun Heo authored
    Node addition failure is detected by testing return value of
    sysfs_addfm_finish() which returns the number of added and removed
    nodes.  As the function is called as the last step of addition right
    on top of error handling block, the if blocks looked like the
    following.
    
    	if (sysfs_addrm_finish(&acxt))
    		success handling, usually return;
    	/* fall through to error handling */
    
    This is the opposite of usual convention in sysfs and makes the code
    difficult to understand.  This patch inverts the test and makes those
    blocks look more like others.
    Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
    Cc: Gabriel C <nix.or.die@googlemail.com>
    Cc: Miles Lane <miles.lane@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    967e35dc
dir.c 29.7 KB