• Ilpo Järvinen's avatar
    net/sunrpc/xprtsock.c: some common code found · 1f0fa154
    Ilpo Järvinen authored
    $ diff-funcs xs_udp_write_space net/sunrpc/xprtsock.c
    net/sunrpc/xprtsock.c xs_tcp_write_space
     --- net/sunrpc/xprtsock.c:xs_udp_write_space()
     +++ net/sunrpc/xprtsock.c:xs_tcp_write_space()
    @@ -1,4 +1,4 @@
    - * xs_udp_write_space - callback invoked when socket buffer space
    + * xs_tcp_write_space - callback invoked when socket buffer space
      *                             becomes available
      * @sk: socket whose state has changed
      *
    @@ -7,12 +7,12 @@
      * progress, otherwise we'll waste resources thrashing kernel_sendmsg
      * with a bunch of small requests.
      */
    -static void xs_udp_write_space(struct sock *sk)
    +static void xs_tcp_write_space(struct sock *sk)
     {
     	read_lock(&sk->sk_callback_lock);
    
    -	/* from net/core/sock.c:sock_def_write_space */
    -	if (sock_writeable(sk)) {
    +	/* from net/core/stream.c:sk_stream_write_space */
    +	if (sk_stream_wspace(sk) >= sk_stream_min_wspace(sk)) {
     		struct socket *sock;
     		struct rpc_xprt *xprt;
    
    
    $ codiff net/sunrpc/xprtsock.o net/sunrpc/xprtsock.o.new
    net/sunrpc/xprtsock.c:
      xs_tcp_write_space | -163
      xs_udp_write_space | -163
     2 functions changed, 326 bytes removed
    
    net/sunrpc/xprtsock.c:
      xs_write_space | +179
     1 function changed, 179 bytes added
    
    net/sunrpc/xprtsock.o.new:
     3 functions changed, 179 bytes added, 326 bytes removed, diff: -147
    Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1f0fa154
xprtsock.c 54.2 KB