• Andrew Morton's avatar
    [PATCH] tpm_bios indexing fix · 1c40f7d4
    Andrew Morton authored
    It generates warnings:
    
    drivers/char/tpm/tpm_bios.c: In function `get_event_name':
    drivers/char/tpm/tpm_bios.c:223: warning: cast from pointer to integer of different size
    drivers/char/tpm/tpm_bios.c:223: warning: cast from pointer to integer of different size
    drivers/char/tpm/tpm_bios.c:223: warning: cast from pointer to integer of different size
    drivers/char/tpm/tpm_bios.c:224: warning: cast from pointer to integer of different size
    drivers/char/tpm/tpm_bios.c:224: warning: cast from pointer to integer of different size
    drivers/char/tpm/tpm_bios.c:224: warning: cast from pointer to integer of different size
    
    and I'm not sure what the code is doing there, but it seems wrong.  We're
    using the address of the buffer rather than the contents of it.
    
    The patch adds more nasty typecasting, but I think the whole arrangement could
    be done in a more typesafe manner.
    
    Cc: Kylene Jo Hall <kjhall@us.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    1c40f7d4
tpm_bios.c 11.6 KB