• Alan Cox's avatar
    tty: fix sanity check · 1aa4bed8
    Alan Cox authored
    The WARN_ON() that was added to tty_reopen can be triggered in the specific
    case of a hangup occurring during a re-open of a tty which is not in the
    middle of being otherwise closed.
    
    In that case however the WARN() is bogus as we don't hold the neccessary
    locks to make a correct decision.
    
    The case we should be checking is "if the ldisc is not changing and reopen
    is occuring". We could drop the WARN_ON but for the moment the debug is more
    valuable even if it means taking a mutex as it will find any other cases.
    Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    1aa4bed8
tty_io.c 76.7 KB