• Igor Perminov's avatar
    rt2x00: Fix for race condition while update beacon · 17512dc3
    Igor Perminov authored
    The patch "Implement set_tim callback for all drivers" can cause kernel
    oops in rt73usb_write_beacon. The oops is caused by one of the following
    race conditions:
    * In case of two near calls to set_tim: rt2x00lib_beacondone_iter is
    cleaning the beacon skb, whereas rt73usb_write_beacon is still using it.
    * In case of two near updates of beacon: first as the result of set_tim
    and second as the result of a call from an application (e.g. hostapd).
    This patch fixes the race condition by rearranging the update logic and
    guarding rt2x00_intf->beacon->skb with a mutex.
    Signed-off-by: default avatarIgor Perminov <igor.perminov@inbox.ru>
    Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    17512dc3
rt2x00.h 24.8 KB