• Eduardo Habkost's avatar
    xen_alloc_ptpage: cast PFN_PHYS() argument to unsigned long · 169ad16b
    Eduardo Habkost authored
    Currently paravirt_ops alloc_p*() uses u32 for the pfn args. We should
    change that later, but while the pfn parameter is still u32, we need to
    cast the PFN_PHYS() argument at xen_alloc_ptpage() to unsigned long,
    otherwise it will lose bits on the shift.
    
    I think PFN_PHYS() should behave better when fed with smaller integers,
    but a cast to unsigned long won't be enough for all cases on 32-bit PAE,
    and a cast to u64 would be overkill for most users of PFN_PHYS().
    
    We could have two different flavors of PFN_PHYS: one for low pages
    only (unsigned long) and another that works for any page (u64)),
    but while we don't have it, we will need the cast to unsigned long on
    xen_alloc_ptpage().
    Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
    Acked-by: default avatarJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    169ad16b
enlighten.c 40.4 KB