Commits · 9fade4bf8eed3db2fd1306968da4d51bc611aca3 · linux / linux-davinci-2.6.23

03 Dec, 2006 40 commits

NetLabel: return the correct error for translated CIPSOv4 tags · 9fade4bf

Paul Moore authored Nov 17, 2006

The CIPSOv4 translated tag #1 mapping does not always return the correct error
code if the desired mapping does not exist; instead of returning -EPERM it
returns -ENOSPC indicating that the buffer is not large enough to hold the
translated value.  This was caused by failing to check a specific error
condition.  This patch fixes this so that unknown mappings return
-EPERM which is consistent with the rest of the related CIPSOv4 code.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

9fade4bf

NetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types · 91b1ed0a

Paul Moore authored Nov 17, 2006

While the original CIPSOv4 code had provisions for multiple tag types the
implementation was not as great as it could be, pushing a lot of non-tag
specific processing into the tag specific code blocks. This patch fixes that
issue making it easier to support multiple tag types in the future.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

91b1ed0a

NetLabel: add tag verification when adding new CIPSOv4 DOI definitions · 6ce61a7c

Paul Moore authored Nov 17, 2006

Currently the CIPSOv4 engine does not do any sort of checking when a new DOI
definition is added. The tags are still verified but only as a side effect of
normal NetLabel operation (packet processing, socket labeling, etc.) which
would cause application errors due to the faulty configuration. This patch
adds tag checking when new DOI definition are added allowing us to catch these
configuration problems when they happen.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

6ce61a7c

NetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer · 05e00cbf

Paul Moore authored Nov 17, 2006

Right now the NetLabel code always jumps into the CIPSOv4 layer to determine if
a CIPSO IP option is present. However, we can do this check directly in the
NetLabel code by making use of the CIPSO_V4_OPTEXIST() macro which should save
us a function call in the common case of not having a CIPSOv4 option present.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

05e00cbf

NetLabel: make netlbl_lsm_secattr struct easier/quicker to understand · 701a90ba

Paul Moore authored Nov 17, 2006

The existing netlbl_lsm_secattr struct required the LSM to check all of the
fields to determine if any security attributes were present resulting in a lot
of work in the common case of no attributes.  This patch adds a 'flags' field
which is used to indicate which attributes are present in the structure; this
should allow the LSM to do a quick comparison to determine if the structure
holds any security attributes.

Example:

 if (netlbl_lsm_secattr->flags)
	/* security attributes present */
 else
	/* NO security attributes present */
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

701a90ba

NetLabel: change netlbl_secattr_init() to return void · c6fa82a9

Paul Moore authored Nov 17, 2006

The netlbl_secattr_init() function would always return 0 making it pointless
to have a return value.  This patch changes the function to return void.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

c6fa82a9

NetLabel: convert the unlabeled accept flag to use RCU · cd28786d

Paul Moore authored Nov 17, 2006

Currently the NetLabel unlabeled packet accept flag is an atomic type and it
is checked for every non-NetLabel packet which comes into the system but rarely
ever changed.  This patch changes this flag to a normal integer and protects it
with RCU locking.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

cd28786d

NetLabel: use gfp_t instead of int where it makes sense · 1f758d93

Paul Moore authored Nov 17, 2006

There were a few places in the NetLabel code where the int type was being used
instead of the gfp_t type, this patch corrects this mistake.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>

1f758d93

[TCP]: Tidy up skb_entail · 352d4800

Arnaldo Carvalho de Melo authored Nov 17, 2006

Heck, it even saves us some few bytes:

[acme@newtoy net-2.6.20]$ codiff -f /tmp/tcp.o.before ../OUTPUT/qemu/net-2.6.20/net/ipv4/tcp.o
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp.c:
  tcp_sendpage |   -7
  tcp_sendmsg  |   -5
 2 functions changed, 12 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

352d4800

[NETROM]: Use kmemdup · eafff86d
Arnaldo Carvalho de Melo authored Nov 17, 2006
```
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
```
eafff86d

[AX25]: Use kmemdup · 0459d70a

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/ax25.ko.before /tmp/ax25.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_out.c:
  ax25_send_frame |   -8
 1 function changed, 8 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_route.c:
  ax25_rt_autobind |  -15
 1 function changed, 15 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/af_ax25.c:
  ax25_make_new |  -33
 1 function changed, 33 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/sysctl_net_ax25.c:
  ax25_register_sysctl |  -21
 1 function changed, 21 bytes removed

/tmp/ax25.ko.after:
 4 functions changed, 77 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

0459d70a

[DECNET]: Use kmemdup · c66b721a

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/decnet.ko.before /tmp/decnet.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/decnet/dn_dev.c:
  dn_dev_sysctl_register |  -51
 1 function changed, 51 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

c66b721a

[DCCP]: Use kmemdup · eed73417

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/dccp.ko.before /tmp/dccp.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/dccp/feat.c:
  __dccp_feat_init      |  -16
  dccp_feat_change_recv |  -55
  dccp_feat_clone       |  -56
 3 functions changed, 127 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

eed73417

[IPV6]: Use kmemdup · af879cc7

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/ipv6.ko.before /tmp/ipv6.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/ip6_output.c:
  ip6_output      |  -52
  ip6_append_data |   +2
 2 functions changed, 2 bytes added, 52 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/addrconf.c:
  addrconf_sysctl_register |  -27
 1 function changed, 27 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/tcp_ipv6.c:
  tcp_v6_syn_recv_sock  |  -32
  tcp_v6_parse_md5_keys |  -24
 2 functions changed, 56 bytes removed

/tmp/ipv6.ko.after:
 5 functions changed, 2 bytes added, 135 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

af879cc7

[TCP] minisocks: Use kmemdup and LIMIT_NETDEBUG · c6786240

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/tcp_minisocks.o.before /tmp/tcp_minisocks.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_minisocks.c:
  tcp_check_req |  -44
 1 function changed, 44 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

c6786240

[IPV4]: Use kmemdup in net/ipv4/devinet.c · 42e5ea46

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/devinet.o.before /tmp/devinet.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/devinet.c:
  devinet_sysctl_register |  -38
 1 function changed, 38 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

42e5ea46

[NETLABEL]: Use kmemdup in cipso_ipv4.c · fac5d731

Arnaldo Carvalho de Melo authored Nov 17, 2006

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before /tmp/cipso_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c:
  cipso_v4_cache_add |  -46
 1 function changed, 46 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

fac5d731

[TCP_IPV4]: Use kmemdup where appropriate · f6685938

Arnaldo Carvalho de Melo authored Nov 17, 2006

Also use a variable to avoid the longish tp->md5sig_info-> use
in tcp_v4_md5_do_add.

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/tcp_ipv4.o.before /tmp/tcp_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_ipv4.c:
  tcp_v4_md5_do_add     |  -62
  tcp_v4_syn_recv_sock  |  -32
  tcp_v4_parse_md5_keys |  -86
 3 functions changed, 180 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

f6685938

[TCP_IPV4]: CodingStyle cleanups, no code change · 7174259e

Arnaldo Carvalho de Melo authored Nov 17, 2006

Mostly related to CONFIG_TCP_MD5SIG recent merge.
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

7174259e

[DCCP] CCID2: Code optimizations · 32aac18d

Andrea Bittau authored Nov 16, 2006

These are code optimizations which are relevant when dealing with large
windows.  They are not coded the way I would like to, but they do the job for
the short-term.  This patch should be more neat.

Commiter note: Changed the seqno comparisions to use {after,before}48 to handle
               wrapping.
Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

32aac18d

[NET]: Conditionally use bh_lock_sock_nested in sk_receive_skb · 58a5a7b9

Arnaldo Carvalho de Melo authored Nov 16, 2006

Spotted by Ian McDonald, tentatively fixed by Gerrit Renker:

http://www.mail-archive.com/dccp%40vger.kernel.org/msg00599.html

Rewritten not to unroll sk_receive_skb, in the common case, i.e. no lock
debugging, its optimized away.
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

58a5a7b9

[DCCP]: One NET_INC_STATS() could be NET_INC_STATS_BH in dccp_v4_err() · e523a155
Arnaldo Carvalho de Melo authored Nov 16, 2006
```
Spotted by Eric Dumazet in tcp_v4_rcv().
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
```
e523a155

[DCCP]: Introduce DCCP_{BUG{_ON},CRIT} macros, use enum:8 for the ccid3 states · 3c695262

Gerrit Renker authored Nov 15, 2006

This patch tackles the following problem:
       * the ccid3_hc_{t,r}x_sock define ccid3hc{t,r}x_state as `u8', but
         in reality there can only be a few, pre-defined enum names
       * this necessitates addiditional checking for unexpected values
         which would otherwise be caught by the compiler
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

3c695262

[UDPLite]: udplite.h needs ip6_checksum.h · 6bb100b9
David S. Miller authored Nov 15, 2006
```
Signed-off-by: David S. Miller <davem@davemloft.net>
```
6bb100b9

[NET/IPv4]: Make udp_push_pending_frames static · 078250d6

Gerrit Renker authored Nov 15, 2006

udp_push_pending_frames is only referenced within
net/ipv4/udp.c and hence can remain static.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

078250d6

[IPV6]: udp.c build fix · 7d9e9b3d
David S. Miller authored Nov 14, 2006
```
Signed-off-by: David S. Miller <davem@davemloft.net>
```
7d9e9b3d

[NET]: More dccp endianness annotations. · 7d533f94

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

7d533f94

[NET]: Preliminaty annotation of skb->csum. · 1f61ab5c

Al Viro authored Nov 14, 2006

It's still not completely right; we need to split it into anon unions
of __wsum and unsigned - for cases when we use it for partial checksum
and for offset of checksum in skb
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

1f61ab5c

[NET] driver/s390/net: Checksum annotations. · 5a5a852e

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

5a5a852e

[NET]: netfilter checksum annotations · 43bc0ca7

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

43bc0ca7

[NET]: ipvs checksum annotations. · f9214b26

Al Viro authored Nov 16, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

f9214b26

[NET]: IP header modifier helpers annotations. · 5c78f275

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

5c78f275

[NET]: Make mangling a checksum (0 -> 0xffff on the wire) explicit. · f6ab0288
Al Viro authored Nov 16, 2006
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
f6ab0288

[NET]: Annotate __skb_checksum_complete() and friends. · b51655b9

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b51655b9

[NET]: Annotate ip_vs_checksum_complete() and callers. · b1550f22

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b1550f22

[NET]: Annotate skb_copy_and_csum_bits() and callers. · 81d77662

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

81d77662

[NET]: Annotate skb_checksum() and callers. · 2bbbc868

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

2bbbc868

[NET]: Annotate callers of the reset of checksum.h stuff. · 5f92a738

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

5f92a738

[NET]: Annotate callers of csum_partial_copy_...() and csum_and_copy...() in net/* · 5084205f
Al Viro authored Nov 14, 2006
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
5084205f

[NET]: Annotate csum_partial() callers in net/* · 44bb9363

Al Viro authored Nov 14, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

44bb9363