1. 13 Feb, 2007 2 commits
    • Jean Delvare's avatar
      i2c-ali1563: Fix device initialization · 849be516
      Jean Delvare authored
      The i2c-ali1563 initialization looks quite broken to me:
      * If the I/O space isn't enabled, we forcibly set 3 bits in
        the PCI configuration space instead of just the one enabling
        the I/O space.
      * After that we pretend to check if the write worked, but we
        don't actually read the new value from the register.
      * It's probably not a good idea to enable the I/O space if no
        base address has been set.
      
      So I propose the following changes to that part of the driver:
      * Merge ali1563_enable() into ali1563_setup().
      * Check the base address before the I/O space enabled bit.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Acked-by: default avatarRudolf Marek <r.marek@assembler.cz>
      849be516
    • Jean Delvare's avatar
      i2c-ali1563: Improve the status messages · 69735698
      Jean Delvare authored
      Improve the status messages printed by the i2c-ali1563 driver.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Cc: Rudolf Marek <r.marek@assembler.cz>
      69735698
  2. 12 Feb, 2007 38 commits