1. 09 Aug, 2006 1 commit
    • Dmitry Mishin's avatar
      [NET]: add_timer -> mod_timer() in dst_run_gc() · 7c91767a
      Dmitry Mishin authored
      Patch from Dmitry Mishin <dim@openvz.org>:
      
      Replace add_timer() by mod_timer() in dst_run_gc
      in order to avoid BUG message.
      
             CPU1                            CPU2
      dst_run_gc()  entered           dst_run_gc() entered
      spin_lock(&dst_lock)                   .....
      del_timer(&dst_gc_timer)         fail to get lock
             ....                         mod_timer() <--- puts 
                                                       timer back
                                                       to the list
      add_timer(&dst_gc_timer) <--- BUG because timer is in list already.
      
      Found during OpenVZ internal testing.
      
      At first we thought that it is OpenVZ specific as we
      added dst_run_gc(0) call in dst_dev_event(),
      but as Alexey pointed to me it is possible to trigger
      this condition in mainstream kernel.
      
      F.e. timer has fired on CPU2, but the handler was preeempted
      by an irq before dst_lock is tried.
      Meanwhile, someone on CPU1 adds an entry to gc list and
      starts the timer.
      If CPU2 was preempted long enough, this timer can expire
      simultaneously with resuming timer handler on CPU1, arriving
      exactly to the situation described.
      Signed-off-by: default avatarDmitry Mishin <dim@openvz.org>
      Signed-off-by: default avatarKirill Korotaev <dev@openvz.org>
      Signed-off-by: default avatarAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7c91767a
  2. 08 Aug, 2006 8 commits
  3. 07 Aug, 2006 3 commits
  4. 06 Aug, 2006 28 commits