- 10 Jan, 2006 40 commits
-
-
Adrian Bunk authored
The Coverity checker spotted this dead code. Signed-off-by:
Adrian Bunk <bunk@stusta.de> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
"extern inline" doesn't make much sense. Signed-off-by:
-
Jesper Juhl authored
Remove redundant casts of k*alloc() return values in security/selinux/ss/services.c Signed-off-by:
Jesper Juhl <jesper.juhl@gmail.com> Acked-by:
Stephen Smalley <sds@epoch.ncsc.mil> Cc: James Morris <jmorris@namei.org> Signed-off-by:
-
Jesper Juhl authored
Remove unneeded casts of kmalloc() return value in binfmt_elf. Signed-off-by:
-
Jesper Juhl authored
Decrease the number of pointer derefs in drivers/md/multipath.c Benefits of the patch: - Fewer pointer dereferences should make the code slightly faster. - Size of generated code is smaller - improved readability Signed-off-by:
Ingo Molnar <mingo@elte.hu> Cc: Alasdair G Kergon <agk@redhat.com> Acked-by:
NeilBrown <neilb@suse.de> Signed-off-by:
-
Jesper Juhl authored
Decrease the number of pointer derefs in kernel/exit.c Benefits of the patch: - Fewer pointer dereferences should make the code slightly faster. - Size of generated code is smaller - improved readability Signed-off-by:
-
Jiri Slaby authored
Wrap all the code to 80 chars on a line. `}\nelse' changed to `} else'. Clean whitespaces in header file. Signed-off-by:
Jiri Slaby <xslaby@fi.muni.cz> Signed-off-by:
-
Jiri Slaby authored
Firmware loading via hotplug added. Cleanup firmware old-way fields in header file. Signed-off-by:
-
Jiri Slaby authored
Pci probing functions added, most of functions rewrited because of it (some for loops were redundant). Used PCI_DEVICE macro. dev_* used for printing wherever possible. Renamed some functions to have isicom_ in the name. Signed-off-by:
Laurent Riffard <laurent.riffard@free.fr> Signed-off-by:
-
Jiri Slaby authored
Move some code from one place to another. Get rid of ugly ifdefs in code in next p[patches, so here create functions and macros to enable it. Rename some functions and align some code to 80 chars. Signed-off-by:
-
Jiri Slaby authored
Type which is needed to have accurate size was converted to [us]{8,16}. Removed void * cast. Signed-off-by: -
Jiri Slaby authored
Trailing spaces and tabs and space used for indentation deleted. Indented content of structures. Switch/case indent. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
Alan Cox <alan@redhat.com> Signed-off-by:
-
Grant Coady authored
drivers/char/n_hdlc.c:194: warning: `n_hdlc_tty_room' declared `static' but never defined Signed-off-by:
Grant Coady <gcoady@gmail.com> Signed-off-by:
-
Alan Cox authored
The API and code have been through various bits of initial review by serial driver people but they definitely need to live somewhere for a while so the unconverted drivers can get knocked into shape, existing drivers that have been updated can be better tuned and bugs whacked out. This replaces the tty flip buffers with kmalloc objects in rings. In the normal situation for an IRQ driven serial port at typical speeds the behaviour is pretty much the same, two buffers end up allocated and the kernel cycles between them as before. When there are delays or at high speed we now behave far better as the buffer pool can grow a bit rather than lose characters. This also means that we can operate at higher speeds reliably. For drivers that receive characters in blocks (DMA based, USB and especially virtualisation) the layer allows a lot of driver specific code that works around the tty layer with private secondary queues to be removed. The IBM folks need this sort of layer, the smart serial port people do, the virtualisers do (because a virtualised tty typically operates at infinite speed rather than emulating 9600 baud). Finally many drivers had invalid and unsafe attempts to avoid buffer overflows by directly invoking tty methods extracted out of the innards of work queue structs. These are no longer needed and all go away. That fixes various random hangs with serial ports on overflow. The other change in here is to optimise the receive_room path that is used by some callers. It turns out that only one ldisc uses receive room except asa constant and it updates it far far less than the value is read. We thus make it a variable not a function call. I expect the code to contain bugs due to the size alone but I'll be watching and squashing them and feeding out new patches as it goes. Because the buffers now dynamically expand you should only run out of buffering when the kernel runs out of memory for real. That means a lot of the horrible hacks high performance drivers used to do just aren't needed any more. Description: tty_insert_flip_char is an old API and continues to work as before, as does tty_flip_buffer_push() [this is why many drivers dont need modification]. It does now also return the number of chars inserted There are also tty_buffer_request_room(tty, len) which asks for a buffer block of the length requested and returns the space found. This improves efficiency with hardware that knows how much to transfer. and tty_insert_flip_string_flags(tty, str, flags, len) to insert a string of characters and flags For a smart interface the usual code is len = tty_request_buffer_room(tty, amount_hardware_says); tty_insert_flip_string(tty, buffer_from_card, len); More description! At the moment tty buffers are attached directly to the tty. This is causing a lot of the problems related to tty layer locking, also problems at high speed and also with bursty data (such as occurs in virtualised environments) I'm working on ripping out the flip buffers and replacing them with a pool of dynamically allocated buffers. This allows both for old style "byte I/O" devices and also helps virtualisation and smart devices where large blocks of data suddenely materialise and need storing. So far so good. Lots of drivers reference tty->flip.*. Several of them also call directly and unsafely into function pointers it provides. This will all break. Most drivers can use tty_insert_flip_char which can be kept as an API but others need more. At the moment I've added the following interfaces, if people think more will be needed now is a good time to say int tty_buffer_request_room(tty, size) Try and ensure at least size bytes are available, returns actual room (may be zero). At the moment it just uses the flipbuf space but that will change. Repeated calls without characters being added are not cumulative. (ie if you call it with 1, 1, 1, and then 4 you'll have four characters of space. The other functions will also try and grow buffers in future but this will be a more efficient way when you know block sizes. int tty_insert_flip_char(tty, ch, flag) As before insert a character if there is room. Now returns 1 for success, 0 for failure. int tty_insert_flip_string(tty, str, len) Insert a block of non error characters. Returns the number inserted. int tty_prepare_flip_string(tty, strptr, len) Adjust the buffer to allow len characters to be added. Returns a buffer pointer in strptr and the length available. This allows for hardware that needs to use functions like insl or mencpy_fromio. Signed-off-by:Hirokazu Takata <takata@linux-m32r.org> Signed-off-by:
Serge Hallyn <serue@us.ibm.com> Signed-off-by:
Jeff Dike <jdike@addtoit.com> Signed-off-by:
John Hawkes <hawkes@sgi.com> Signed-off-by:
Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by:
-
Andrew Morton authored
Looks like JSM will be uncompilable after the TTY layer rework is merged into Linus's post-2.6.15 tree. It was complex to fix - the maintainers were notified in September. Cc: Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by:
-
Paul Jackson authored
Changes to the serial driver to remove flip buffers have broken the serial jsm driver. It doesn't even compile anymore. The jsm driver was enabled in only one defconfig - ppc64. In order to keep defconfigs building, disable CONFIG_SERIAL_JSM for the time being. Signed-off-by:
Paul Jackson <pj@sgi.com> Signed-off-by:
-
Adrian Bunk authored
This patch contains the following possible cleanups: - #if 0 the following unused functions: - zlib_deflate/deflate.c: zlib_deflateSetDictionary - zlib_deflate/deflate.c: zlib_deflateParams - zlib_deflate/deflate.c: zlib_deflateCopy - zlib_inflate/infblock.c: zlib_inflate_set_dictionary - zlib_inflate/infblock.c: zlib_inflate_blocks_sync_point - zlib_inflate/inflate_sync.c: zlib_inflateSync - zlib_inflate/inflate_sync.c: zlib_inflateSyncPoint - remove the following unneeded EXPORT_SYMBOL's: - zlib_deflate/deflate_syms.c: zlib_deflateCopy - zlib_deflate/deflate_syms.c: zlib_deflateParams - zlib_inflate/inflate_syms.c: zlib_inflateSync - zlib_inflate/inflate_syms.c: zlib_inflateSyncPoint Signed-off-by:
-
Adrian Bunk authored
This patch contains the following cleanups: - there's no need for ext3_count_free() #ifndef EXT3FS_DEBUG - having prototypes for ext3_count_free() in two different headers is nonsense Signed-off-by:
-
Adrian Bunk authored
There's no need for ext2_count_free() #ifndef EXT2FS_DEBUG. Signed-off-by:
-
Adrian Bunk authored
This patch contains the possible cleanups including the following: - every file should #include the headers containing the prototypes for it's global functions - make needlessly global functions static - kyro/STG4000Interface.h: #include video/kyro.h and linux/pci.h instead of a manual "struct pci_dev" - i810_main.{c,h}: prototypes for static functions belong to the C file Signed-off-by:"Antonino A. Daplas" <adaplas@hotpop.com> Signed-off-by:
-
Jean Delvare authored
No need to define RTC_NUM_RESOURCES, it doesn't add any value to the code. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Tobias Klauser authored
Use ARRAY_SIZE macro instead of sizeof(x)/sizeof(x[0]) and remove duplicates of ARRAY_SIZE. Signed-off-by:
Tobias Klauser <tklauser@nuerscht.ch> Signed-off-by:
-
Jesper Juhl authored
ICC likes to complain about storage class not being first, GCC doesn't care much (except for cases like "inline static"). have a hard time seeing how it could break anything. Thanks to Gabriel A. Devenyi for pointing out http://linuxicc.sourceforge.net/ which is what made me create this patch. Signed-off-by:
-
Adrian Bunk authored
This patch contains the following cleanups: - make a needlessly global function static - remove the unneeded global function irport_probe Signed-off-by:
-
Jesper Juhl authored
Small spelling, formating & similar fixes to stable_kernel_rules.txt Signed-off-by:
-
Jesper Juhl authored
Remove obsolete patch from Documentation/locks.txt Signed-off-by:
-
Jesper Juhl authored
Spelling fixes, formating changes and corrections for Documentation/filesystems/ext3.txt Signed-off-by:
-
Randy Dunlap authored
Typos/corrections. A few extra additions on top of Randy's fixes. Signed-off-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
-
Martin Waitz authored
Previously kernel-doc silently ignored missing parameter descriptions for preprocessor macros. Now that all such omissions are fixed up we can warn about them in kernel-doc to be able to keep it that way. Signed-off-by:
Martin Waitz <tali@admingilde.org> Signed-off-by:
-
Martin Waitz authored
Fix typos in comments to remove kernel-doc warnings. Signed-off-by:
-
Martin Waitz authored
Signed-off-by:
-
Martin Waitz authored
when ignoring all DocBook output files git-status output becomes meaningful again. Signed-off-by:
-
Jesper Juhl authored
Signed-off-by:
-
Ville Syrjala authored
Current console blanking code is broken. It will first do a normal blank, then start the VESA blank timer if vesa_off_interval != 0, and then proceed to do the VESA blanking directly. After the timer expires it will do the VESA blanking a second time. Also the vesa_powerdown() function doesn't allow all VESA modes to be used. With this patch the behaviour is: 1. Blank: vesa_off_interval != 0 -> Do normal blank vesa_off_interval == 0 -> Do VESA blank 2. Start the VESA blank timer if vesa_off_interval != 0 and vesa_power_mode != 0. It also gets rid of the limiting vesa_powerdown() function. Signed-off-by:Ville Syrjala <syrjala@sci.fi> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by:
-
Thomas Koeller authored
While the code in fbmem.c allows for hooking read/write access to non-linear frame buffers by means of fb_read and fb_write in struct fb_ops, I could not find a way tho access the actual frame buffer memory from within these routines. I therefore had to patch fbmem.c, to be able to retrieve a pointer to struct fb_info from the 'file' argument to these functions. The second hunk of the patch is not strictly required, I only did that for symmetry reasons (and the code is somewhat shorter). Signed-off-by:
Thomas Koeller <thomas@koeller.dyndns.org> Acked-by:
"Antonino A. Daplas" <adaplas@gmail.com> Signed-off-by:
-
YOSHIFUJI Hideaki authored
Signed-off-by:
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by:
-
Antonino A. Daplas authored
Replace kmalloc with kzalloc Signed-off-by:
Antonino Daplas <adaplas@pol.net> Signed-off-by:
-
Antonino A. Daplas authored
- replace kmalloc with kzalloc - remove repeated define (FONTCHHCNT) - remove unneeded local variable (redraw) in ypan_{up|down}_redraw - add and delete cursor timer in fbcon_switch() if old_info != info Signed-off-by: -
Antonino A. Daplas authored
The i810fb suspend and resume hooks have suffered bitrot over time. Update to current framework, but functionality still not guaranteed to work. Signed-off-by:
-
